Press n or j to go to the next uncovered block, b, p or k for the previous block.
| 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 | 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 9364x 9364x 9364x 9364x 9364x 27923x 27923x 27923x 27923x 27923x 27923x 27923x 27923x 27923x 9364x 9364x 1x 1x 9364x 9364x 8898x 8898x 9364x 9364x 216x 216x 9364x 9364x 235x 235x 235x 12x 12x 223x 235x 49x 39x 39x 10x 49x 1x 1x 1x 1x 49x 223x 223x 223x 9364x 9364x | import {Issue} from "../issue";
import {ABAPRule} from "./_abap_rule";
import * as Statements from "../abap/2_statements/statements";
import * as Expressions from "../abap/2_statements/expressions";
import {BasicRuleConfig} from "./_basic_rule_config";
import {RuleTag} from "./_irule";
import {ABAPFile} from "../abap/abap_file";
export class MixReturningConf extends BasicRuleConfig {
}
export class MixReturning extends ABAPRule {
private conf = new MixReturningConf();
public getMetadata() {
return {
key: "mix_returning",
title: "Mix of returning and exporting",
shortDescription: `Checks that methods don't have a mixture of returning and exporting/changing parameters`,
// eslint-disable-next-line max-len
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-either-returning-or-exporting-or-changing-but-not-a-combination`,
tags: [RuleTag.Styleguide, RuleTag.SingleFile],
};
}
private getMessage(): string {
return "Don't mix RETURNING and EXPORTING/CHANGING parameters in a single method.";
}
public getConfig() {
return this.conf;
}
public setConfig(conf: MixReturningConf) {
this.conf = conf;
}
public runParsed(file: ABAPFile): Issue[] {
const ret: Issue[] = [];
const stru = file.getStructure();
if (stru === undefined) {
return [];
}
for (const def of stru.findAllStatements(Statements.MethodDef)) {
if (!def.findFirstExpression(Expressions.MethodDefReturning)) {
continue;
}
if (def.findFirstExpression(Expressions.MethodDefExporting)
|| def.findFirstExpression(Expressions.MethodDefChanging)) {
const token = def.getFirstToken();
const issue = Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
ret.push(issue);
}
}
return ret;
}
}
|